Update codex to 0.115.0 - #73
Closed
codex-acp-ci-app[bot] wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously Failed Tests And Reasons
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts->should authenticate with keyTimed out because API-key auth could block waiting for
account/login/completed; later also had snapshot drift from updatedmodel/listand thread-start response shape.src/__tests__/CodexACPAgent/CodexAcpClient.test.ts->should authenticate with a gatewayTimed out during session creation because MCP startup waiting depended on a deprecated notification path; later hit
logout failed: Read-only file system (os error 30)in this environment.src/__tests__/CodexACPAgent/mcp-session.test.ts->should return configured mcpTimed out for the same MCP startup wait path.
What I Changed And Why
src/CodexEventHandler.tsto explicitly handle newly generated notification variants (hook/*,item/autoApprovalReview/*,command/exec/outputDelta) so the switch stays exhaustive and type-safe after the schema update.src/CodexAcpServer.tsto stop blocking session creation on deprecated MCP-startup notification behavior; session MCP server names are now derived from request-configured MCP servers.src/CodexAcpClient.tsauth flow so API-key auth returns immediately after successful login request, while ChatGPT login still waits for completion (optionally filtered byloginId), preventing auth deadlocks introduced by updated login semantics.src/CodexAppServerClient.tslogin-completion waiting to supportloginIdmatching for compatibility with updated account login events.src/__tests__/CodexACPAgent/CodexAcpClient.test.tsto avoid environment-dependent logout failure, and refreshed the changed auth snapshot insrc/__tests__/CodexACPAgent/data/auth-with-key.jsonto match the updated Codex payload shape.